[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

Wed May 17 01:05:03 PDT 2023

pmatos added a comment.

In D150670#4347150 <https://reviews.llvm.org/D150670#4347150>, @dschuff wrote:

> FWIW X86 seems to do something similar elsewhere in this file (https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGBuiltin.cpp#L985-L986), although it doesn't seem common otherwise. I think I'd be OK with this approach (and it does seem better than trying to mess with instcombine or a new TTI hook or something)

Oh - I missed that X86 bit. That gives me some confidence that this approach makes sense. I will work on a new patch with 64bit support and tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150670/new/

https://reviews.llvm.org/D150670