[PATCH] D150545: [NFC][Py Reformat] Reformat python files in llvm

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 00:17:30 PDT 2023


jhenderson accepted this revision.
jhenderson added a comment.

I picked a few random files and saw no issues from my point of view in them. LGTM.

In D150545#4343142 <https://reviews.llvm.org/D150545#4343142>, @JDevlieghere wrote:

> LGTM. I would include something in the commit to make things easier for downstream users. If there are conflicts, they're probably better off keeping their version (`git checkout --ours`) and rerunning the same black command. I would also make sure to specify which version of black to use (23) as the output changes between versions and some distros might have older versions (when using their package manager instead of pip).

This sounds like a good plan to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150545/new/

https://reviews.llvm.org/D150545



More information about the llvm-commits mailing list