[PATCH] D141712: [GVN] Improve PRE on load instructions

Tue May 16 22:14:08 PDT 2023

TimNN added a comment.

I strongly suspect that this patch is breaking the Rust compiler when building against LLVM head:

  Instruction does not dominate all uses!
    %11 = load i32, ptr %10, align 4, !range !10, !alias.scope !6314, !noalias !6319
    %19 = phi i32 [ %8, %9 ], [ %11, %32 ]
  in function _RINvNtCsbJsLLO9YF7d_9rustc_hir10intravisit9walk_bodyINtNtCs7c017R9yI2R_10rustc_lint4late18LateContextAndPassNtBT_33BuiltinCombinedModuleLateLintPassEEBT_
  LLVM ERROR: Broken function found, compilation aborted!
  error: could not compile `rustc_lint` (lib)

>From https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/19373

Changes since the last successful run of that build bot: https://github.com/llvm/llvm-project/compare/d3b9d8b28f8e9fde41a4136c28f458347d9bb292...6a2f52a3a00bdfc8bd4edf6592099a7a749d324e

(I don't have a minimized repro yet).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141712/new/

https://reviews.llvm.org/D141712