[PATCH] D150625: [PseudoProbe] Only emit discriminstor in FS-AFDO mode.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 21:35:31 PDT 2023


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG456eb4b5bffe: [PseudoProbe] Only emit discriminstor in FS-AFDO mode. (authored by hoy).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150625/new/

https://reviews.llvm.org/D150625

Files:
  llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp


Index: llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp
===================================================================
--- llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp
+++ llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp
@@ -45,9 +45,11 @@
   uint64_t Discriminator = 0;
   // For now only block probes have FS discriminators. See
   // MIRFSDiscriminator.cpp for more details.
-  if (DebugLoc &&
-      !DILocation::isPseudoProbeDiscriminator(DebugLoc->getDiscriminator()))
+  if (EnableFSDiscriminator && DebugLoc &&
+      (Type == (uint64_t)PseudoProbeType::Block))
     Discriminator = DebugLoc->getDiscriminator();
+  assert((EnableFSDiscriminator || Discriminator == 0) &&
+         "Discriminator should not be set in non-FSAFDO mode");
   SmallVector<InlineSite, 8> InlineStack(llvm::reverse(ReversedInlineStack));
   Asm->OutStreamer->emitPseudoProbe(Guid, Index, Type, Attr, Discriminator,
                                     InlineStack, Asm->CurrentFnSym);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150625.522892.patch
Type: text/x-patch
Size: 986 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230517/63d98cd1/attachment.bin>


More information about the llvm-commits mailing list