[PATCH] D150664: MachineCombiner: use height in improvesCriticialPathLen()

[Shiva Chen via Phabricator via llvm-commits]

shiva0217 added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCombiner.cpp:265
+    // Get the first instruction that uses MO
+    MachineRegisterInfo::use_iterator UI = MRI->use_begin(MO.getReg());
+    if (UI == MRI->use_end())
----------------
Should it go through all users as following?

 for (MachineInstr &UseInstr : MRI->use_instructions(MO.getReg())) {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150664/new/

https://reviews.llvm.org/D150664