[PATCH] D149073: [ASAN] Support memory checks on experimental.vp.strided.load/store.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 marked an inline comment as done.
fakepaper56 added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1367
+          IID == Intrinsic::experimental_vp_strided_load) {
+        Stride = VPI->getOperand(PtrOpNo + 1);
+        // Don't use alignment of pointer cause of byte stride.
----------------
reames wrote:
> This alignment check is overly conservative for constant stride which is a multiple of the alignment.
> 
> Organizationally, this should probably be inside the instrumentation logic.  The alignment here appears to be the base alignment, and the element alignment can be computed from it and the stride as needed.
Good point. I had fixed the issue in the latest revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149073/new/

https://reviews.llvm.org/D149073