[PATCH] D149743: [RISCV][CodeGen] Support Zdinx on RV32 codegen

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 18:08:27 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:2328
     int64_t CVal = cast<ConstantSDNode>(Addr.getOperand(1))->getSExtValue();
-    if (isInt<12>(CVal)) {
+    if (isInt<12>(CVal + ZdinxRange)) {
       Base = Addr.getOperand(0);
----------------
Does this fail UBSAN if CVal is 0x7fffffffffffffff?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149743/new/

https://reviews.llvm.org/D149743



More information about the llvm-commits mailing list