[PATCH] D150741: [FS-AFDO] Clean up non-zero discriminator for pseudo probes at the first FS discriminator pass.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fsafdo_probe.ll:68
 !8 = !DILocation(line: 7, column: 15, scope: !9)
-!9 = !DILexicalBlockFile(scope: !6, file: !1, discriminator: 0)
+!9 = !DILexicalBlockFile(scope: !6, file: !1, discriminator: 2)
 !10 = !DILocation(line: 7, column: 3, scope: !9)
----------------
wenlei wrote:
> hoy wrote:
> > wenlei wrote:
> > > why is this test change? If anything, I was expecting non-zero -> zero for probe discriminators..
> > This is to test the non-zero discriminator can be cleaned up by the first FS discriminator pass.
> Oh, I see. Can you maybe add a comment? Is the "from 0 -> xxx" covering the check on clean up non-zero discriminator?  
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150741/new/

https://reviews.llvm.org/D150741