[PATCH] D150625: [PseudoProbe] Only emit discriminstor in FS-AFDO mode.

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

thanks for the fix, lgtm.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp:49
+  if (EnableFSDiscriminator && DebugLoc &&
+      (Type == (uint64_t)PseudoProbeType::Block))
     Discriminator = DebugLoc->getDiscriminator();
----------------
should we put in an assert to make sure we catch lurking non-zero discriminators? i.e. when FS is off, probe should always have zero discriminator?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150625/new/

https://reviews.llvm.org/D150625