[PATCH] D149943: [hwasan] support hwasan-match-all-tag flag for hwasan meminstrinsic calls

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:674
+      Int8PtrTy,
+      ArrayRef(&HWAsanMemTransferArgTys[0], HWAsanMemTransferArgSize), false);
+  const size_t HWAsanMemsetArgSize = UseMatchAllCallback ? 4 : 3;
----------------
vitalybuka wrote:
> Can you make use of this constructor
> ```
> template <size_t N>
>     /*implicit*/ constexpr ArrayRef(const std::array<T, N> &Arr)
> ```
> 
> ```
> FunctionType *HWAsanMemTransferFnTy = FunctionType::get(
>       Int8PtrTy,       ArrayRef(HWAsanMemTransferArgTys), false);
> ```
> Can you make use of this constructor
> ```
> template <size_t N>
>     /*implicit*/ constexpr ArrayRef(const std::array<T, N> &Arr)
> ```

sorry, copied wrong one 
```
template <size_t N>
    /*implicit*/ constexpr ArrayRef(const T (&Arr)[N]) : Data(Arr), Length(N) {}

```
> 
> ```
> FunctionType *HWAsanMemTransferFnTy = FunctionType::get(
>       Int8PtrTy,       ArrayRef(HWAsanMemTransferArgTys), false);
> ```




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149943/new/

https://reviews.llvm.org/D149943