[PATCH] D150688: [cmake] Set CMP0091 to fix Windows builds after the cmake_minimum_required bump

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Out of curiosity - what are the symptoms that this change fixes, and which build configurations does it affect? (I would expect that regular builds with just llvm+clang would pass at least?) But I do agree that the new behaviour of `CMP0091` probably does conflict with `ChooseMSVCCRT.cmake`.

Tangentially; for libc++ builds, `ChooseMSVCCRT.cmake` isn't ever included and used so far. So for the sake of libc++ at the moment, I'd go with keeping `CMP0091` set to the new behaviour - which probably is the more convenient way of interacting with the choice of CRT going forward.

I do see that `CMakePolicy.cmake` doesn't get included in libc++ builds either, so I think that should all be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150688/new/

https://reviews.llvm.org/D150688