[PATCH] D150029: [VPlan] Print IR flags for VPRecipeWithIRFlags.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1072
   }
+
+  FastMathFlags getFastMathFlags() const {
----------------
Ayal wrote:
> Also under #if as it's used only by printFlags()?
updated, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:597
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+void VPRecipeWithIRFlags::printFlags(raw_ostream &O) const {
+  if (OpType == OperationType::PossiblyExactOp && ExactFlags.IsExact)
----------------
Ayal wrote:
> switch?
Updated, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:599
+  if (OpType == OperationType::PossiblyExactOp && ExactFlags.IsExact)
+    O << " exact";
+  else if (OpType == OperationType::OverflowingBinOp) {
----------------
Ayal wrote:
> Thanks for covering the FMF cases!
> Do "exact" and calls also miss test coverage?
Extra tests added in 6c35d423c82b


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150029/new/

https://reviews.llvm.org/D150029