[PATCH] D150713: [llvm-debuginfo-analyzer] Support both Reference and Type attrs in single DIE

[Scott Linder via Phabricator via llvm-commits]

scott.linder created this revision.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, hiraditya.
Herald added a project: All.
scott.linder requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Relax the assumption that at most one Reference-or-Type-like attribute is
present on a DWARF DIE.

Add support for at most one Type attribute (i.e. DW_AT_import xor
DW_AT_type) and separately at most one Reference attribute (i.e.
DW_AT_specification xor DW_AT_abstract_origin xor ...).

Update comment describing old assumption and tag it as a "FIXME" to
reflect the fact that this is perhaps still not general enough.

Add a test based on the case which led me to encounter the bug in the
wild.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150713

Files:
  llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h
  llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp
  llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/dw-at-specification.o
  llvm/test/tools/llvm-debuginfo-analyzer/DWARF/dw-at-specification.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150713.522757.patch
Type: text/x-patch
Size: 6944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230516/de900cca/attachment.bin>