[PATCH] D150688: [cmake] Set CMP0091 to fix Windows builds after the cmake_minimum_required bump

Mark de Wever via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 10:57:14 PDT 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for the patch! When this fixes the CI I'm happy with it.
I expect with CMake 3.15 the selection could be done cleaner, but that can be done in a separate patch by the compiler-rt maintainers.



================
Comment at: cmake/Modules/CMakePolicy.cmake:13
 endif()
+# CMP0091: MSVC runtime library flags are selected by an abstraction.
+# New in CMake 3.15. https://cmake.org/cmake/help/latest/policy/CMP0091.html
----------------
Maybe put this on top so the policies are ordered by the CMake version introducing them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150688/new/

https://reviews.llvm.org/D150688



More information about the llvm-commits mailing list