[PATCH] D150674: [RISCV] Set GenCrashDialog=false for various report_fatal_error calls in lib/Target/RISCV

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

In D150674#4346704 <https://reviews.llvm.org/D150674#4346704>, @MaskRay wrote:

> `report_fatal_error` is a lazy error reporting mechanism that should be avoided. Adding `false` (`exit(1)` instead of `abort()`) just papers over the issue...

Yes, it would be good to have a better error reporting mechanism in many of these cases and excise these uses of report_fatal_error - but AFAIK the infrastructure just isn't there for many of these to report a proper error with context (corrections welcome!). I think we're in agreement this patch isn't fundamentally improving the situation, just making some minor incremental improvements on what we have today.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150674/new/

https://reviews.llvm.org/D150674