[PATCH] D150600: [Lanai] Use backwards scavenging in frame index elimination

[Jay Foad via Phabricator via llvm-commits]

foad updated this revision to Diff 522650.
foad added a comment.

Switch to scavengeRegisterBackwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150600/new/

https://reviews.llvm.org/D150600

Files:
  llvm/lib/Target/Lanai/LanaiRegisterInfo.cpp
  llvm/lib/Target/Lanai/LanaiRegisterInfo.h


Index: llvm/lib/Target/Lanai/LanaiRegisterInfo.h
===================================================================
--- llvm/lib/Target/Lanai/LanaiRegisterInfo.h
+++ llvm/lib/Target/Lanai/LanaiRegisterInfo.h
@@ -34,6 +34,8 @@
 
   bool requiresRegisterScavenging(const MachineFunction &MF) const override;
 
+  bool supportsBackwardScavenger() const override { return true; }
+
   bool eliminateFrameIndex(MachineBasicBlock::iterator II, int SPAdj,
                            unsigned FIOperandNum,
                            RegScavenger *RS = nullptr) const override;
Index: llvm/lib/Target/Lanai/LanaiRegisterInfo.cpp
===================================================================
--- llvm/lib/Target/Lanai/LanaiRegisterInfo.cpp
+++ llvm/lib/Target/Lanai/LanaiRegisterInfo.cpp
@@ -167,7 +167,7 @@
     assert(RS && "Register scavenging must be on");
     Register Reg = RS->FindUnusedReg(&Lanai::GPRRegClass);
     if (!Reg)
-      Reg = RS->scavengeRegister(&Lanai::GPRRegClass, II, SPAdj);
+      Reg = RS->scavengeRegisterBackwards(Lanai::GPRRegClass, II, false, SPAdj);
     assert(Reg && "Register scavenger failed");
 
     bool HasNegOffset = false;
@@ -235,10 +235,11 @@
         .addReg(FrameReg)
         .addImm(-Offset);
     MI.eraseFromParent();
-  } else {
-    MI.getOperand(FIOperandNum).ChangeToRegister(FrameReg, /*isDef=*/false);
-    MI.getOperand(FIOperandNum + 1).ChangeToImmediate(Offset);
+    return true;
   }
+
+  MI.getOperand(FIOperandNum).ChangeToRegister(FrameReg, /*isDef=*/false);
+  MI.getOperand(FIOperandNum + 1).ChangeToImmediate(Offset);
   return false;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150600.522650.patch
Type: text/x-patch
Size: 1610 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230516/5df2c833/attachment.bin>