[PATCH] D150684: [LoopReroll] Remove unused LoopReroll pass

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: fhahn, reames, efriedma, mkazantsev.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This pass was introduced in 2013 and has not been enabled by default (or even been part of the pass pipeline) since that time. As far as I know, there is no active work on it, and no path towards default enablement. There is a long list of miscompiles reported against this pass (most of https://github.com/llvm/llvm-project/issues?q=is%3Aissue+is%3Aopen+loop-reroll), which have remained unfixed for years.

In the interest of not keeping unused code in tree, this removes the pass entirely. Should interest in default enablement for this pass appear, it would need a from-scratch review anyway.


https://reviews.llvm.org/D150684

Files:
  llvm/include/llvm/Transforms/Scalar/LoopReroll.h
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/Scalar/CMakeLists.txt
  llvm/lib/Transforms/Scalar/LoopRerollPass.cpp
  llvm/test/Transforms/LoopReroll/basic.ll
  llvm/test/Transforms/LoopReroll/basic32iters.ll
  llvm/test/Transforms/LoopReroll/complex_reroll.ll
  llvm/test/Transforms/LoopReroll/external_use.ll
  llvm/test/Transforms/LoopReroll/extra_instr.ll
  llvm/test/Transforms/LoopReroll/indvar_with_ext.ll
  llvm/test/Transforms/LoopReroll/negative.ll
  llvm/test/Transforms/LoopReroll/nonconst_lb.ll
  llvm/test/Transforms/LoopReroll/ptrindvar.ll
  llvm/test/Transforms/LoopReroll/reduction.ll
  llvm/test/Transforms/LoopReroll/reroll_with_dbg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150684.522642.patch
Type: text/x-patch
Size: 184368 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230516/0f3f0254/attachment-0001.bin>