[PATCH] D150230: [GlobalISel] Implement some binary reassociations, G_ADD for now

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D150230#4344697 <https://reviews.llvm.org/D150230#4344697>, @aemerson wrote:

> @arsenm ping. Do you know why the AMDGPU test doesn't work with update_mir_test_checks?

What is the error? update_mir_test_checks is pretty buggy with multiple run lines and multiple checks. I sometimes need to delete individual run lines to get it t work



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.s.buffer.load.ll:5019-5021
+  ; GFX6-NEXT:   [[COPY6:%[0-9]+]]:vgpr_32 = COPY [[COPY5]]
+  ; GFX6-NEXT:   [[V_ADD_CO_U32_e64_:%[0-9]+]]:vgpr_32, dead [[V_ADD_CO_U32_e64_1:%[0-9]+]]:sreg_64 = V_ADD_CO_U32_e64 [[COPY6]], [[COPY4]], 0, implicit $exec
+  ; GFX6-NEXT:   [[S_MOV_B32_:%[0-9]+]]:sreg_32 = S_MOV_B32 0
----------------
This result is worse so we'd ideally have something regbank aware 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150230/new/

https://reviews.llvm.org/D150230