[PATCH] D150669: [Support] Forward GenCrashDiag argument from report_fatal_error(Error, bool)

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 07:20:18 PDT 2023


asb created this revision.
asb added reviewers: lhames, RKSimon, JDevlieghere.
Herald added subscribers: wingo, pmatos, sameer.abuasal, hiraditya.
Herald added a project: All.
asb requested review of this revision.
Herald added a project: LLVM.

The boolean GenCrashDiag argument was previous just discarded, which seems to be an oversight that existed when this overload was first added.

Reviewers added based on those who last touched this function. I don't think there's an easy way to test this, but let me know if I'm wrong on that point.


https://reviews.llvm.org/D150669

Files:
  llvm/lib/Support/Error.cpp


Index: llvm/lib/Support/Error.cpp
===================================================================
--- llvm/lib/Support/Error.cpp
+++ llvm/lib/Support/Error.cpp
@@ -149,7 +149,7 @@
     raw_string_ostream ErrStream(ErrMsg);
     logAllUnhandledErrors(std::move(Err), ErrStream);
   }
-  report_fatal_error(Twine(ErrMsg));
+  report_fatal_error(Twine(ErrMsg), GenCrashDiag);
 }
 
 } // end namespace llvm


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150669.522607.patch
Type: text/x-patch
Size: 407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230516/ee100946/attachment.bin>


More information about the llvm-commits mailing list