[PATCH] D149438: Remove some includes that shouldn't be needed any longer

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 07:10:28 PDT 2023

bjope added a comment.

In D149438#4343022 <https://reviews.llvm.org/D149438#4343022>, @aeubanks wrote:

> if you're fairly certain these are correct, I'd say no need for a review for include cleanups in the future :)

Ok. Thanks. I've pushed without review on some rare occasions, but usually prefer to get a second opinion to make sure I do not mess up things.
But I'll try to avoid taking up valuable time for those making lots of reviews in this project for trivial patches like this one.

I was slightly worried that I could have missed something with how the LLVM libs works (that removing things from Scalar.cpp could break something).
But since code compiles and check-all passes, then I guess that it should be fine.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list