[PATCH] D149938: [AMDGPU][InferAddressSpaces] Only rewrite address-spaces that can be trivially casted to flat for llvm.amdgcn.flat.atomic.{fadd,fmax,fmin} (2/2)

Juan Manuel Martinez CaamaƱo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 06:27:22 PDT 2023


jmmartinez marked 3 inline comments as done.
jmmartinez added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:1091
+    };
+    if (!llvm::all_of(InOutAS, IsFlatAS))
+      return nullptr;
----------------
arsenm wrote:
> I don't understand why you are checking both address spaces. The old address space had to have been flat?
You're right. I fixed the code to match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149938/new/

https://reviews.llvm.org/D149938



More information about the llvm-commits mailing list