[PATCH] D149746: [PowerPC][lit] Recognize triple ppc64le.*-linux

Tulio Magno Quites Machado Filho via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 06:19:17 PDT 2023


tuliom added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:148
+            if re.match(r'^ppc64le.*-linux', target_triple):
+                features.add('target=powerpc64le-linux')
 
----------------
qiucf wrote:
> Why here is `target=` instead of `target-`?
Because the tests expect `target=`, e.g.:
https://github.com/llvm/llvm-project/blob/main/llvm/docs/TestingGuide.rst?plain=1#L542
https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/fast_math.f90#L71
https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGenCoroutines/pr56329.cpp#L5

AFAIU, in order to start accepting `target-powerpc.*`, all tests using `target=powerpc.*` would have to be modified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149746/new/

https://reviews.llvm.org/D149746



More information about the llvm-commits mailing list