[PATCH] D150666: [WIP][GlobalISel] Combiner Intrinsic Matching

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I'm finding the lack of equivalent of ComplexPatterns and PatFrags to be frustrating. Should there be a new intermediate pattern source class to abstract over instructions?



================
Comment at: llvm/test/TableGen/GICombinerEmitter/match-tree.td:35
 
+def int_dummy : DefaultAttrsIntrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>;
+let TargetPrefix = "foo" in
----------------
Should have one that has side effects and one that doesn't to cover both G_INTRINSIC* cases.

Also, maybe try one with multiple return values. Should theoretically be matchable 


================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:63
 namespace {
+static constexpr StringRef IntrinsicIDVarName = "$intrin_id";
+
----------------
These are supposed to use StringLiteral 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150666/new/

https://reviews.llvm.org/D150666