[PATCH] D150583: [IR] Add getAccessType to Instruction

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/IR/Instruction.cpp:749
+  case Instruction::Store:
+    return getOperand(0)->getType();
+  case Instruction::Load:
----------------
nikic wrote:
> getPointerOperand()
Sorry, I meant to say getValueOperand() here...


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:900
+  MemAccessTy AccessTy(Inst->getAccessType(), MemAccessTy::UnknownAddressSpace);
+  assert(AccessTy.MemTy);
   if (const StoreInst *SI = dyn_cast<StoreInst>(Inst)) {
----------------
Is this assertion right? After all we're also handling memcpy etc below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150583/new/

https://reviews.llvm.org/D150583