[PATCH] D150583: [IR] Add getAccessType to Instruction. NFC

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 06:01:49 PDT 2023


luke marked 2 inline comments as done.
luke added inline comments.


================
Comment at: llvm/lib/IR/Instruction.cpp:753
+  case Instruction::AtomicCmpXchg:
+    return getType();
+  case Instruction::Call:
----------------
nikic wrote:
> This is incorrect for cmpxchg, which returns a struct.
Thanks, good catch. I've plugged this into LoopStrengthReduce, which seems to have made the same mistake, so this patch is no longer NFC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150583/new/

https://reviews.llvm.org/D150583



More information about the llvm-commits mailing list