[compiler-rt] 51015af - [asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception`
Alvin Wong via llvm-commits
llvm-commits at lists.llvm.org
Tue May 16 04:54:29 PDT 2023
Author: Alvin Wong
Date: 2023-05-16T19:53:49+08:00
New Revision: 51015af773775160c22df9a8252d34270f2698a2
URL: https://github.com/llvm/llvm-project/commit/51015af773775160c22df9a8252d34270f2698a2
DIFF: https://github.com/llvm/llvm-project/commit/51015af773775160c22df9a8252d34270f2698a2.diff
LOG: [asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception`
This appears to be a leftover from when these tests were first added in
D62927. Because of this, these tests had never run with `check-asan` or
`check-asan-dynamic`.
I've tested locally that these tests do pass on both i686 MSVC and MinGW
targets. They are disabled for 64-bit though, and I believe no LLVM
buildbots are testing for 32-bit Windows targets.
Differential Revision: https://reviews.llvm.org/D150270
Added:
Modified:
compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp
compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp
compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp
compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp
compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp
Removed:
################################################################################
diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp
index 20d14bdb57e8..a34a18fc35e2 100644
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp
@@ -1,7 +1,6 @@
// RUN: %clang_cl_asan %Od %s %Fe%t %MD
// RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
// UNSUPPORTED: asan-64-bits
-// REQUIRES: asan-rtl-heap-interception
#include <stdio.h>
#include <windows.h>
diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp
index b71a4a2ce688..3bce875cda88 100644
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp
@@ -3,7 +3,6 @@
// RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %te.exe %t.dll 2>&1 | FileCheck %s
// REQUIRES: asan-dynamic-runtime
// REQUIRES: asan-32-bits
-// REQUIRES: asan-rtl-heap-interception
#include <cassert>
#include <stdio.h>
diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp
index 10621082a5a8..38b8b176af27 100644
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp
@@ -3,7 +3,6 @@
// RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %te.exe %t.dll 2>&1 | FileCheck %s
// REQUIRES: asan-dynamic-runtime
// REQUIRES: asan-32-bits
-// REQUIRES: asan-rtl-heap-interception
#include <cassert>
#include <stdio.h>
diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp
index 95fbff2435ef..c93f1b8151d1 100644
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp
@@ -1,7 +1,6 @@
// RUN: %clang_cl_asan %Od %s %Fe%t %MD
// RUN: %env_asan_opts=windows_hook_rtl_allocators=true %run %t 2>&1 | FileCheck %s
// UNSUPPORTED: asan-64-bits
-// REQUIRES: asan-rtl-heap-interception
#include <assert.h>
#include <stdio.h>
diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp
index 99ff341be30b..d3594cae066f 100644
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp
@@ -1,7 +1,6 @@
// RUN: %clang_cl_asan %Od %s %Fe%t %MD
// RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
// UNSUPPORTED: asan-64-bits
-// REQUIRES: asan-rtl-heap-interception
#include <assert.h>
#include <stdio.h>
More information about the llvm-commits
mailing list