[compiler-rt] 3237f56 - [asan][win][test] Disable interception_failure_test.cpp for static asan

[Alvin Wong via llvm-commits]

Author: Alvin Wong
Date: 2023-05-16T19:53:12+08:00
New Revision: 3237f568403b80a6df47dd88dcfb03cb3a99b633

URL: https://github.com/llvm/llvm-project/commit/3237f568403b80a6df47dd88dcfb03cb3a99b633
DIFF: https://github.com/llvm/llvm-project/commit/3237f568403b80a6df47dd88dcfb03cb3a99b633.diff

LOG: [asan][win][test] Disable interception_failure_test.cpp for static asan

This test checks that asan does not intercept user-provided libc
functions, but on Windows the static asan runtime does intercept static
copies of libc functions, so this test is invalid for said environment.
It used to fail from a different linker error, but this no longer
happens with newer WinSDK. Refer to comments on
https://reviews.llvm.org/D149549.

Differential Revision: https://reviews.llvm.org/D150349

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/interception_failure_test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/interception_failure_test.cpp b/compiler-rt/test/asan/TestCases/interception_failure_test.cpp
index 7e2413ec2a237..918fa8e82bf74 100644
--- a/compiler-rt/test/asan/TestCases/interception_failure_test.cpp
+++ b/compiler-rt/test/asan/TestCases/interception_failure_test.cpp
@@ -7,9 +7,12 @@
 // RUN: %clangxx_asan -O3 %s -o %t && %run %t 2>&1 | FileCheck %s
 // XFAIL: target={{.*freebsd.*}}
 
-// On Windows, defining strtoll in a static build results in linker errors, but
-// it works with the dynamic runtime.
-// XFAIL: win32-static-asan
+// On Windows, the static runtime build _will_ intercept static copies of libc
+// functions, making this test invalid.
+// In addition, defining strtol in a static build used to result in linker
+// errors with libucrt.lib, but this stopped happening somewhere between WinSDK
+// 10.0.19041.0 and 10.0.22621.0 due to some changes in its implementation.
+// UNSUPPORTED: win32-static-asan
 
 // On NetBSD, defining strtol in a static build results in linker errors, but
 // it works with the dynamic runtime.