[PATCH] D150658: [GlobalIsel][x86] Legalize G_AND, G_OR, and G_XOR for AVX2

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nit

If you're picking up x86 legality rules I think step 1 is to remove all this legacy rule stuff



================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-and-or-xor.mir:119
+    ; CHECK-NEXT: RET 0, implicit [[COPY]](<4 x s64>)
+    %0:_(<4x s64>) = IMPLICIT_DEF
+    %1:_(<4x s64>) = G_OR %0, %0
----------------
Formatting is consistently off, missing space before x 


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-and-or-xor.mir:130-136
+registers:
+  - { id: 0, class: _, preferred-register: '' }
+  - { id: 1, class: _, preferred-register: '' }
+liveins:
+fixedStack:
+stack:
+constants:
----------------
Can drop all this stuff 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150658/new/

https://reviews.llvm.org/D150658