[PATCH] D147871: ValueTracking: Implement computeKnownFPClass for sqrt

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 04:00:47 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4491
+            (InterestedClasses & fcNan) != fcNone &&
+            cannotBeOrderedLessThanZeroImpl(II->getArgOperand(0), TLI, false,
+                                            Depth + 1))
----------------
foad wrote:
> This should reuse info from the first call to computeKnownFPClass, instead of making a second call to cannotBeOrderedLessThanZeroImpl.
Oh right, this predates when I added cannotBeOrderedLessThanZero to KnownFPClass


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147871/new/

https://reviews.llvm.org/D147871



More information about the llvm-commits mailing list