[PATCH] D148230: ValueTracking: fadd +0 cannot return -0

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 03:47:31 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:3945
+  // If we know there are no denormals, nothing can be flushed to zero.
+  if (isKnownNeverSubnormal())
+    return true;
----------------
foad wrote:
> Nit: might as well push this into the PositiveZero/default case.
That wouldn't short circuit the attribute parsing 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148230/new/

https://reviews.llvm.org/D148230



More information about the llvm-commits mailing list