[PATCH] D150375: [FuncSpec] Replace LoopInfo with BlockFrequencyInfo.

Tue May 16 02:57:17 PDT 2023

labrinea added a comment.

In D150375#4345303 <https://reviews.llvm.org/D150375#4345303>, @ChuanqiXu wrote:

> In D150375#4345226 <https://reviews.llvm.org/D150375#4345226>, @labrinea wrote:
>
>> In D150375#4337042 <https://reviews.llvm.org/D150375#4337042>, @ChuanqiXu wrote:
>>
>>> Interesting. Have you measured with spec2017?
>>
>> Hi. I measured (without PGO) but didn't see any changes. The main drive for this change is to enable specialization of literal constants (D150649 <https://reviews.llvm.org/D150649>), which would otherwse trigger too often with LoopInfo.
>
> Do you measured it with fulllto? If yes, I feel the change looks good.

Yes, both default -O3 and full LTO pipelines as shown on the description.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150375/new/

https://reviews.llvm.org/D150375