[PATCH] D150550: [RISCV] Refactor predicates for rvv intrinsic patterns.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan marked an inline comment as done.
jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:682
+                       !eq(vti.Scalar, f64));
+  list<Predicate> Predicates = !cond(!and(IsFloat, !eq(vti.SEW, 16)) : [HasVInstructionsF16],
+                                     !and(IsFloat, !eq(vti.SEW, 32)) : [HasVInstructionsAnyF],
----------------
craig.topper wrote:
> Why not use !eq(vti.Scalar, f16), !eq(vti.Scalar, f32), !eq(vti.Scalar, f64), !eq(vti.Scalar, i64) as the conditions and get rid of `IsFloat`?
The field `Scalar` depends on XLEN for integer vector, we need to use `SEW` to determine the spported integer EEW.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150550/new/

https://reviews.llvm.org/D150550