[PATCH] D150605: LLT: Add some stub constructors for FP types

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

I'm a bit neutral regarding this change, I can't comment on whether it's better to have the information in the types or the operations.
Though I'm also wondering if binding the semantics to FP operation wouldn't make more sense?

However if we're going this direction I would prefer to see all relevant uses of `LLT::scalar` looked at and replaced with `::float` where needed (not just within the AMD backend) to avoid further fragmentation.



================
Comment at: llvm/include/llvm/CodeGen/LowLevelType.h:74
 
+  /// Get a 16-bit IEEE half value.
+  static constexpr LLT float16() {
----------------
small nit: I would add that to make it clear those ctors were added with the intention of going that way later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150605/new/

https://reviews.llvm.org/D150605