[PATCH] D150633: [X86]check that Uses, Defs are same for entries in memory folding table

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:115
+      auto& MemInstRec = *MemInst->TheDef;
+      auto ListOfUses_l = RegInstRec.getValueAsListOfDefs("Uses");
+      auto ListOfUses_r = MemInstRec.getValueAsListOfDefs("Uses");
----------------
Variable names should not contain underscores.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:123
+        ret = false;
+      for (unsigned long i = 0; i < ListOfUses_l.size(); i++) {
+        if (ListOfUses_l[i] != ListOfUses_r[i])
----------------
Can we use `operator==` for the vectors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150633/new/

https://reviews.llvm.org/D150633