[PATCH] D146438: [RISCV][MC] Refine MCInstrAnalysis based on registers used

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/unittests/Target/RISCV/MCInstrAnalysisTest.cpp:65
+  EXPECT_THAT(Analysis->isTerminator(beq()), IsTrue());
+  EXPECT_THAT(Analysis->isTerminator(cbeqz()), IsTrue());
+  EXPECT_THAT(Analysis->isTerminator(jal(RISCV::X0)), IsTrue());
----------------
I think the idiom is `EXPECT_TRUE` and `EXPECT_FALSE` for functions that return `bool`.

`EXPECT_THAT ..* IsTrue()` is for a type that converts to a `bool`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146438/new/

https://reviews.llvm.org/D146438