[PATCH] D149533: Regen some old tests; NFC

Mon May 15 17:05:21 PDT 2023

craig.topper added inline comments.

================
Comment at: llvm/test/CodeGen/ARM/sub-cmp-peephole.ll:7
 define i32 @f(i32 %a, i32 %b) nounwind ssp {
+; V8-LABEL: f:
+; V8:       @ %bb.0: @ %entry
----------------
RKSimon wrote:
> goldstein.w.n wrote:
> > RKSimon wrote:
> > > Where has the V7 coverage gone? 
> > > Where has the V7 coverage gone? 
> > 
> > I think there is a bug somewhere. `-mtriple=arm-apple-darwin` simply does not generate automatic checks. Guess drop this one from regen and update it by hand in the known-non-zero patch?
> Sure, or update it manually here (remove the extra RUN etc.) - as long as you remove the NOTE from the top then it should be fine.
I wonder if the triple should be armv7-apple-darwin which has an override in `get_run_handler` llvm/utils/UpdateTestChecks/asm.py. That override defines the regular expression to convert between IR function name and assembly function name.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149533/new/

https://reviews.llvm.org/D149533