[PATCH] D150625: [PseudoProbe] Only emit discriminstor in FS-AFDO mode.

[Hongtao Yu via Phabricator via llvm-commits]

hoy created this revision.
Herald added subscribers: wlei, modimo, wenlei, hiraditya.
Herald added a project: All.
hoy requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Despite previous effort D148569: [PseudoProbe] Clean up dwarf discriminator and avoid duplicating factor. <https://reviews.llvm.org/D148569> to avoid screwing up existing disrminator field, I'm still seeing some call probes getting a non-zero discriminator eventually in non-FS mode. It could be related to callsite merge. While they are investigated I'm disabling discriminator emission for non-FS mode. This avoids breaking the compatiblity with older tools like llvm-profgen and bolt.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150625

Files:
  llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp


Index: llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp
===================================================================
--- llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp
+++ llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp
@@ -45,7 +45,7 @@
   uint64_t Discriminator = 0;
   // For now only block probes have FS discriminators. See
   // MIRFSDiscriminator.cpp for more details.
-  if (DebugLoc &&
+  if (EnableFSDiscriminator && DebugLoc &&
       !DILocation::isPseudoProbeDiscriminator(DebugLoc->getDiscriminator()))
     Discriminator = DebugLoc->getDiscriminator();
   SmallVector<InlineSite, 8> InlineStack(llvm::reverse(ReversedInlineStack));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150625.522380.patch
Type: text/x-patch
Size: 663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230515/15ad6553/attachment.bin>