[PATCH] D149860: [TextAPI] Introduce SymbolSet

[Cyndy Ishida via Phabricator via llvm-commits]

cishida added inline comments.


================
Comment at: llvm/lib/TextAPI/SymbolSet.cpp:28
+  Sym->addTarget(Targ);
+  if (Kind == SymbolKind::ObjectiveCClassEHType)
+    addGlobal(SymbolKind::ObjectiveCClass, Name, Flags, Targ);
----------------
ributzka wrote:
> Why add the corresponding Objective-C class here too? 
hm, I'll try removing it. TAPI always expects these symbols to also have a corresponding class symbol. In theory, these should always exist so it doesn't need to be implicitly added. Though it's possible to export a `ObjectiveCClassEHType` without a `ObjectiveCClass`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149860/new/

https://reviews.llvm.org/D149860