[PATCH] D148761: Emit the correct flags for the PROC CodeView Debug Symbol

Mon May 15 12:45:45 PDT 2023

omjavaid added a comment.

In D148761#4343485 <https://reviews.llvm.org/D148761#4343485>, @dpaoliello wrote:

> @omjavaid this change DID NOT CAUSE THE TEST FAILURE, please see the previous comments where we were discussing this:
>
> In D148761#4326518 <https://reviews.llvm.org/D148761#4326518>, @aaron.ballman wrote:
>
>> In D148761#4324327 <https://reviews.llvm.org/D148761#4324327>, @bolshakov-a wrote:
>>
>>> Thanks! Honestly, I don't know how to reproduce that test results on my Win-x86-64 platform to reveal failure reason.
>>
>> CC @zturner and @clayborg -- this lldb builder has been down for 11 days and there are several failures unrelated to the one in this patch, otherwise I would have reverted this instead of waiting for the author to get back from vacation. Do either of you want to fix or revert to get the bot back into a good state?

I am the owner of lldb-aarch64-windows and i have verified that exactly this commit caused the test to fail. The builder was failing a few test earlier thats why this particular failure got masked.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148761/new/

https://reviews.llvm.org/D148761