[PATCH] D124841: [PowerPC] Stash GPR to VSR if emergency spill slot is not reachable

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 11:24:04 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:1635
   unsigned NewOpcode = 0u;
+  bool ScavengingFailed = RS && RS->getRegsAvailable(RC).none() &&
+                          RS->getRegsAvailable(&PPC::VSFRCRegClass).any();
----------------
FYI you can arrange for `RS` to always be non-nullptr here, by overriding `PPCRegisterInfo::requiresFrameIndexReplacementScavenging` to return `true`. But that changes the code generated for the tests you added here, to the point that I'm not even sure if they're still testing the right thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124841/new/

https://reviews.llvm.org/D124841



More information about the llvm-commits mailing list