[PATCH] D150004: [RISCV][MC] .debug_line/.debug_frame/.eh_frame: emit relocations for assembly input files with relaxation

Mon May 15 11:08:24 PDT 2023

MaskRay added a comment.

In D150004#4340278 <https://reviews.llvm.org/D150004#4340278>, @barannikov88 wrote:

> @MaskRay 
> Thank you for the explanation. Weighting all pros and cons I tend to agree with you.
> I also apologize for taking so much of your time for this simple change.
>
> One point I'd like to clarify, because it was one of my main concerns:
>
>> Are you suggesting to remove the getAssemblerPtr() argument? AIUI this would prevent the fast path from ever being triggered, even for assembly input.
>
> This will not prevent the fast path from being triggered because not all
> expressions contain symbols. An expression can be as simple as 42. I'm not sure
> if this can be the case for special directives like cfa / eh_frame though.

Thank you! Yes, `evaluateAsAbsolute` works on immediate integers like 42.
I think that does not happen with `.debug_line` or `.eh_frame`/`.debug_frame`. The majority (all?) expressions are the difference between two labels...

I'll wait a bit and land this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150004/new/

https://reviews.llvm.org/D150004