[PATCH] D149659: [AArch64][NFC] Refactor the tail-folding option

Mon May 15 10:37:03 PDT 2023

paulwalker-arm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:119-120
+      setInitialBits(TailFoldingOpts::Simple);
+    else
+      reportError(Val);
+
----------------
As discussed offline I'd rather keep the existing ability to specify the individual options manually (i.e. `-sve-tail-folding=reductions+reverse...`), which is more natural than forcing the user to first switch everything off before selectively turning options back on.

================
Comment at: llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h:545
+enum TailFoldingOptsImpl : IntType {
+  Disabled = 0x00,
+  Simple = 0x01,
----------------
Is `Disabled` used anywhere? If not then I think it's best removed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149659/new/

https://reviews.llvm.org/D149659