[PATCH] D150347: [AMDGPU] Improve abs modifier usage

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:5148
+    // Ensure we are not already sinking this operand.
+    if (any_of(Ops, [&](Use *U) { return U->get() == Op; }))
+      continue;
----------------
tsymalla wrote:
> foad wrote:
> > What does this do? Did you mean to check basic blocks here? In any case I am not sure this is required.
> It checks whether one of the operands is registered twice, which appears like common practice amongst other implementations as well 
Oh I see. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150347/new/

https://reviews.llvm.org/D150347