[PATCH] D150312: [MISched] Introduce and use ResourceSegments.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:170
+    MIResourceCutOff("misched-resource-cutoff", cl::Hidden,
+                     cl::desc("Number of intervals to track"), cl::init(10));
+
----------------
fpetrogalli wrote:
> RKSimon wrote:
> > Test coverage?
> The test would just let the command line option, because we do not have any SchedModel upstream that use StartAtCycle.
> 
> Are you saying that I should add an llc invocation that uses this command line option, independently whether or not I can test the codegen changes caused by the value change?
FWIW, the behaviour of changing the cutoff value is tested in the unit test `TEST(ResourceSegments, AddWithCutOff)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150312/new/

https://reviews.llvm.org/D150312