[PATCH] D149646: [LLVM][Uniformity] Propagate temporal divergence explicitly

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds marked 2 inline comments as done.
sameerds added inline comments.


================
Comment at: llvm/include/llvm/ADT/GenericUniformityImpl.h:817-819
+// - Check all PHIs in all exit blocks for inputs defined in the cycle.
+// - For every block B inside C that dominates at least one exit block, check
+//   all uses outside C.
----------------
foad wrote:
> Conceptually you could unify these two cases by looking for blocks B that dominate an exit //edge//; but I have no idea whether DomTree has good support for querying dominance on CFG edges.
I had a cursory look. The DominatorTree interface has methods to query edges dominating uses, but none to check for defs dominating edges.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149646/new/

https://reviews.llvm.org/D149646