[PATCH] D150575: [CodeGen] Make TargetRegisterInfo::supportsBackwardScavenger return true by default

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 07:34:57 PDT 2023


foad created this revision.
foad added reviewers: alex-t, vpykhtin, rampitec, arsenm, zuban32.
Herald added subscribers: luke, StephenFan, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, kbarton, hiraditya, arichardson, jvesely, nemanjai, sdardis.
Herald added a project: All.
foad requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, MaskRay, wdng.
Herald added a project: LLVM.

But override it to return false for all targets that implement
requiresRegisterScavenging. This should make the change NFC for all
in-tree targets, and out-of-tree targets if they add a similar override.

This paves the way for adding backwards scavenging support on a
target-by-target basis. It is preferred over forwards scavenging because
it does not rely on accurate kill flags. When all targets are converted
we can remove the forwards scavenging implementation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150575

Files:
  llvm/include/llvm/CodeGen/TargetRegisterInfo.h
  llvm/lib/Target/AArch64/AArch64RegisterInfo.h
  llvm/lib/Target/AMDGPU/SIRegisterInfo.h
  llvm/lib/Target/ARC/ARCRegisterInfo.h
  llvm/lib/Target/ARM/ARMBaseRegisterInfo.h
  llvm/lib/Target/CSKY/CSKYRegisterInfo.h
  llvm/lib/Target/Hexagon/HexagonRegisterInfo.h
  llvm/lib/Target/Lanai/LanaiRegisterInfo.h
  llvm/lib/Target/LoongArch/LoongArchRegisterInfo.h
  llvm/lib/Target/M68k/M68kRegisterInfo.h
  llvm/lib/Target/Mips/MipsRegisterInfo.h
  llvm/lib/Target/PowerPC/PPCRegisterInfo.h
  llvm/lib/Target/RISCV/RISCVRegisterInfo.h
  llvm/lib/Target/SystemZ/SystemZRegisterInfo.h
  llvm/lib/Target/XCore/XCoreRegisterInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150575.522184.patch
Type: text/x-patch
Size: 9052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230515/15de8ede/attachment.bin>


More information about the llvm-commits mailing list