[PATCH] D149522: [JITLink] Add target features to LinkGraph

[Job Noorman via Phabricator via llvm-commits]

jobnoorman added a comment.

In D149522#4320587 <https://reviews.llvm.org/D149522#4320587>, @lhames wrote:

> In D149522#4318568 <https://reviews.llvm.org/D149522#4318568>, @jobnoorman wrote:
>
>> On a related note: I wonder //why// `SubtargetFeatures` is part of `MC` and not of, say, `TargetParser` (like `Triple`).
>
> Huh. That's a really good question. Maybe we can do this by moving `SubtargetFeatures`?
>
> If we can't do that (or want a short term solution) then we should use `std::vector<std::string>` on the `LinkGraph` and hide the MC dependency in the implementation code. That'll make it easier to fix later without breaking clients.

Even though I opened D150549 <https://reviews.llvm.org/D150549> to try and move `SubtargetFeatures`, I don't expect it to land anytime soon (if ever). Therefore, I've updated this patch to only use `MC` in implementation code. If that patch does land, we can update how features are stored then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149522/new/

https://reviews.llvm.org/D149522