[PATCH] D150447: [MachineSink] Don't reject sinking because of a dead def in isProfitableToSinkTo()

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added a comment.

Sounds like a good idea to me, but I’m not versed enough in MachineIR to put the accept stamp on it.



================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:809-811
+      if (MO.isUse() && !MRI->isConstantPhysReg(Reg) && !TII->isIgnorableUse(MO))
+        // Don't handle non-constant and non-ignorable physical register uses.
+        return false;
----------------
Should probably add brackets around the multiline-if.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150447/new/

https://reviews.llvm.org/D150447