[PATCH] D14327: IR: Add llvm.ldexp and llvm.experimental.constrained.ldexp intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 03:50:41 PDT 2023


arsenm added a comment.

In D14327#4341602 <https://reviews.llvm.org/D14327#4341602>, @nhaehnle wrote:

> This mostly LGTM, but it looks like some GlobalISel legalization is missing relative to SelectionDAG?

Yes. The full legalization expansion should be different, since it's possible to introduce control flow. I didn't see the point handling it right now since the only case I'm sure that expands now is x86 windows, which isn't complete enough to write an end to end test for.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D14327/new/

https://reviews.llvm.org/D14327



More information about the llvm-commits mailing list