[PATCH] D150347: [AMDGPU] Improve abs modifier usage

Thomas Symalla via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 03:36:25 PDT 2023


tsymalla added a comment.

In D150347#4341606 <https://reviews.llvm.org/D150347#4341606>, @arsenm wrote:

> Generic CGP already has tryToSinkFreeOperands, don't know why this wouldn't already work for fabs/fneg

When I tested the implementation in AMD CGP, it did not work because the CSE pass did eliminate some of them again. I will double-check if I can make `tryToSinkFreeOperands` work similarly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150347/new/

https://reviews.llvm.org/D150347



More information about the llvm-commits mailing list